A perky adventure
Usage
-
The README contained everything I needed to easily use the program:
Provide a link to the online tutorial that was used.
-
The program compiles/runs without errors:
would have liked to see instructions for creating the
.jar
file from the source files and ideally aMakefile
that would allow this step to be done by runningmake
-
The program worked as advertised:
Style
-
The code is cleaning divided into modules and multiple files:
not clear how the
gameworld.dat
file is generated frominfo.txt
. I tried modifyinginfo.txt
but the changes didn't seem to be reflected in the game world -
Variable and function names are meaningful:
-
Comments are used where appropriate:
Philosophy
-
The program most closely follows the
ed-like
interface pattern:it would probably be appropriate to read commands from standard input, if present, for testing
-
This choice of pattern is a good one for this application:
-
This program follows the Rule of Silence and Least Surprise:
-
This program follows the Rules of Modularity and Composition:
-
This program follows the Rules of Representation and Simplicity:
there seems to be a good separation of data and logic, but I'm not sure how the
info.txt
file is used to makegamedata.dat
. It would also be more flexible to allow the user to specify an alternate data file as a command line argument.